ecryptfs: disable openssl module to fix build#392196
Merged
K900 merged 1 commit intoNixOS:masterfrom Mar 23, 2025
Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
Contributor
Author
|
Clarification: the last successful build on trunk (https://hydra.nixos.org/build/291812413/nixlog/1) has openssl not found. So while this will likely fall back to some obscure internal implementation for cryptography, this would not be a regression. |
K900
reviewed
Mar 23, 2025
This seems to have been important, as it was a channel blocker until recently [1]. The particular failure [2] was weird in the sense incorrect/incomplete C headers were pulled in. Disabling the openssl module seems to fix the build. OpenSSL was not listed as any sort of dependency, so it probably was not used anyways. [1] NixOS#392175 [2] https://hydra.nixos.org/build/292468814/log
LordGrimmauld
force-pushed
the
ecryptfs-build
branch
from
eb634fb to
85f6d8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to have been important, as it was a channel blocker until recently [1]. The particular failure [2] was weird in the sense incorrect/incomplete C headers were pulled in. Disabling the openssl module seems to fix the build. OpenSSL was not listed as any sort of dependency, so it probably was not used anyways.
[1] #392175
[2] https://hydra.nixos.org/build/292468814/log
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.